Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add java json API #990

Closed

Conversation

DRSchlaubi
Copy link
Contributor

No description provided.

@duncte123
Copy link
Contributor

It would be a good idea to add serialisation/deserialisation helpers as well

@DRSchlaubi
Copy link
Contributor Author

@topi314 topi314 changed the base branch from master to dev December 3, 2023 20:29
Copy link
Contributor

@duncte123 duncte123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meant objects instead of just strings, but this will do for now

@DRSchlaubi
Copy link
Contributor Author

It allows for serialization of JsonPrimitive, JsonArray and JsonObject

@duncte123
Copy link
Contributor

It allows for serialization of JsonPrimitive, JsonArray and JsonObject

But what about

public record MyTrackUserData(long userId, String anotherArg) {}

Currently it cannot handle this for java users

@DRSchlaubi
Copy link
Contributor Author

It allows for serialization of JsonPrimitive, JsonArray and JsonObject

But what about

public record MyTrackUserData(long userId, String anotherArg) {}

Currently it cannot handle this for java users

Well yeah, but kotlinx.serialization has a compiler plugin, which generates the serializer (this is what @serializable does), you cannot do that for a java record, so I can't handle that

@topi314
Copy link
Member

topi314 commented Dec 4, 2023

replaced by lavalink-devs/lavalink-client#12

@topi314 topi314 closed this Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants