Use getOrPut() to resolve race conditon with Links

lavalink-devs · Mar 14, 2024 · f94a045 · f94a045
1 parent 11c4a59
commit f94a045
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/src/main/kotlin/dev/arbjerg/lavalink/client/LavalinkClient.kt b/src/main/kotlin/dev/arbjerg/lavalink/client/LavalinkClient.kt
@@ -104,12 +104,9 @@ class LavalinkClient(val userId: Long) : Closeable, Disposable {
      */
     @JvmOverloads
     fun getOrCreateLink(guildId: Long, region: VoiceRegion? = null): Link {
-        if (!linkMap.containsKey(guildId)) {
-            val bestNode = loadBalancer.selectNode(region, guildId)
-            linkMap[guildId] = Link(guildId, bestNode)
+        return linkMap.getOrPut(guildId) {
+            Link(guildId, loadBalancer.selectNode(region, guildId))
         }
-
-        return linkMap[guildId]!!
     }
 
     /**