Support specifying poToken for WEB client. #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements support for setting a
poTokenand accompanyingvisitorDatavalues which currently apply to theWEBclient. As of a recent change to YT's API, the WEB client may trigger 403 errors which can not be bypassed without specifying apoToken(proof-of-origin token).On a longer timeline, I would like to make this an automatic process that is handled automatically by the source manager however due to the complexity of that, and with current time constraints, this should suffice.
From what I gather, this has been successfully used in production environments by a handful of users.
Token lifetime is currently unknown but seems to be quite a while. With that, the only real drawback to this feature is potentially having to periodically update tokens manually.