Skip to content

Commit

Permalink
Merge pull request #539 from benoitdemaegdt/chore/backfill-quality
Browse files Browse the repository at this point in the history 
chore: remplissage des qualités "satisfactory"
  • Loading branch information
@jendib
jendib authored Feb 1, 2025
2 parents 4d777d3 + c6b93bf commit ef85c3e
Show file tree
Hide file tree
Showing 13 changed files with 554 additions and 61 deletions.
11 changes: 9 additions & 2 deletions .github/scripts/check_data_health.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -76,21 +76,28 @@ function checkGeoJsonDataHealth({ links }) {
allLineStrings.push(feature);
// 2 - check if all properties are present
const properties = feature.properties || {};
const requiredKeys = ['line', 'name', 'status'];
const requiredKeys = ['line', 'name', 'status', 'quality'];
for (const key of requiredKeys) {
if (!properties.hasOwnProperty(key)) {
console.error(`Missing key '${key}' in LineString properties of file: ${filePath}`);
process.exit(1);
}
}

// 3 - check if status is valid
// 3.1 - check if status is valid
const validStatus = ['done', 'wip', 'planned', 'tested', 'postponed', 'unknown', 'variante', 'variante-postponed'];
if (!validStatus.includes(properties.status)) {
console.error(`Invalid status '${properties.status}' in LineString properties of file: ${filePath}`);
process.exit(1);
}

// 3.2 - check if quality is valid
const validQuality = ['satisfactory', 'unsatisfactory'];
if (!validQuality.includes(properties.quality)) {
console.error(`Invalid quality '${properties.quality}' in LineString properties of file: ${filePath}`);
process.exit(1);
}

if (properties.status === 'done') {
// 4.1 - Check if all done section have a doneAt property
if (!properties.hasOwnProperty('doneAt')) {
Expand Down
66 changes: 44 additions & 22 deletions content/voies-cyclables/ligne-1.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,8 @@
"name": "Vaulx-en-Velin Ouest",
"status": "planned",
"type": "bidirectionnelle",
"link": "/voie-lyonnaise-1#vaulx-en-velin-gabriel-péri-à-la-doua-croix-luizet"
"link": "/voie-lyonnaise-1#vaulx-en-velin-gabriel-péri-à-la-doua-croix-luizet",
"quality":"satisfactory"
},
"geometry": {
"type": "LineString",
Expand Down Expand Up @@ -174,7 +175,8 @@
"name": "Croix Luizet",
"status": "planned",
"type": "bidirectionnelle",
"link": "/voie-lyonnaise-1#vaulx-en-velin-gabriel-péri-à-la-doua-croix-luizet"
"link": "/voie-lyonnaise-1#vaulx-en-velin-gabriel-péri-à-la-doua-croix-luizet",
"quality": "satisfactory"
},
"geometry": {
"type": "LineString",
Expand Down Expand Up @@ -202,7 +204,8 @@
"name": "Einstein Est",
"status": "postponed",
"type": "bidirectionnelle",
"link": "/voie-lyonnaise-1#sud-du-campus-de-la-doua"
"link": "/voie-lyonnaise-1#sud-du-campus-de-la-doua",
"quality": "satisfactory"
},
"geometry": {
"type": "LineString",
Expand All @@ -220,7 +223,8 @@
"name": "Einstein INSA",
"status": "planned",
"type": "bidirectionnelle",
"link": "/voie-lyonnaise-1#sud-du-campus-de-la-doua"
"link": "/voie-lyonnaise-1#sud-du-campus-de-la-doua",
"quality": "satisfactory"
},
"geometry": {
"type": "LineString",
Expand All @@ -238,7 +242,8 @@
"name": "Einstein Ouest",
"status": "planned",
"type": "bidirectionnelle",
"link": "/voie-lyonnaise-1#sud-du-campus-de-la-doua"
"link": "/voie-lyonnaise-1#sud-du-campus-de-la-doua",
"quality": "satisfactory"
},
"geometry": {
"type": "LineString",
Expand All @@ -260,7 +265,8 @@
"name": "Boulevard du 11 Nov. 1918 - Est",
"status": "planned",
"type": "bidirectionnelle",
"link": "/voie-lyonnaise-1#stalingrad-nord"
"link": "/voie-lyonnaise-1#stalingrad-nord",
"quality": "satisfactory"
},
"geometry": {
"type": "LineString",
Expand Down Expand Up @@ -305,7 +311,8 @@
"name": "Stalingrad Nord",
"status": "planned",
"type": "voie-verte",
"link": "/voie-lyonnaise-1#stalingrad-nord"
"link": "/voie-lyonnaise-1#stalingrad-nord",
"quality": "satisfactory"
},
"geometry": {
"type": "LineString",
Expand Down Expand Up @@ -335,7 +342,8 @@
"name": "Transbordeur Nord",
"status": "planned",
"type": "bidirectionnelle",
"link": "/voie-lyonnaise-2#boulevard-stalingrad-nord"
"link": "/voie-lyonnaise-2#boulevard-stalingrad-nord",
"quality": "satisfactory"
},
"geometry": {
"type": "LineString",
Expand Down Expand Up @@ -408,7 +416,8 @@
"name": "Tête d'Or",
"status": "planned",
"type": "bidirectionnelle",
"link": "/voie-lyonnaise-1#quai-de-grande-bretagne-et-quai-de-serbie"
"link": "/voie-lyonnaise-1#quai-de-grande-bretagne-et-quai-de-serbie",
"quality": "satisfactory"
},
"geometry": {
"type": "LineString",
Expand All @@ -430,7 +439,8 @@
"status": "done",
"doneAt": "28/03/2023",
"type": "bidirectionnelle",
"link": "/voie-lyonnaise-1#quai-de-grande-bretagne-et-quai-de-serbie"
"link": "/voie-lyonnaise-1#quai-de-grande-bretagne-et-quai-de-serbie",
"quality": "satisfactory"
},
"geometry": {
"type": "LineString",
Expand All @@ -454,7 +464,8 @@
"status": "done",
"doneAt": "28/03/2023",
"type": "bidirectionnelle",
"link": "/voie-lyonnaise-1#quai-de-grande-bretagne-et-quai-de-serbie"
"link": "/voie-lyonnaise-1#quai-de-grande-bretagne-et-quai-de-serbie",
"quality": "satisfactory"
},
"geometry": {
"type": "LineString",
Expand All @@ -478,7 +489,8 @@
"status": "done",
"doneAt": "31/12/2019",
"type": "bidirectionnelle",
"link": "/voie-lyonnaise-1#quai-sarrail-et-quai-augagneur"
"link": "/voie-lyonnaise-1#quai-sarrail-et-quai-augagneur",
"quality": "satisfactory"
},
"geometry": {
"type": "LineString",
Expand All @@ -497,7 +509,8 @@
"status": "done",
"doneAt": "26/04/2024",
"type": "bidirectionnelle",
"link": "/voie-lyonnaise-1#quai-sarrail-et-quai-augagneur"
"link": "/voie-lyonnaise-1#quai-sarrail-et-quai-augagneur",
"quality": "satisfactory"
},
"geometry": {
"type": "LineString",
Expand All @@ -518,7 +531,8 @@
"status": "done",
"doneAt": "28/06/2024",
"type": "bidirectionnelle",
"link": "/voie-lyonnaise-1#quai-sarrail-et-quai-augagneur"
"link": "/voie-lyonnaise-1#quai-sarrail-et-quai-augagneur",
"quality": "satisfactory"
},
"geometry": {
"type": "LineString",
Expand All @@ -536,7 +550,8 @@
"status": "done",
"doneAt": "28/06/2024",
"type": "bidirectionnelle",
"link": "/voie-lyonnaise-1#quai-sarrail-et-quai-augagneur"
"link": "/voie-lyonnaise-1#quai-sarrail-et-quai-augagneur",
"quality": "satisfactory"
},
"geometry": {
"type": "LineString",
Expand All @@ -561,7 +576,8 @@
"status": "done",
"doneAt": "08/07/2022",
"type": "bidirectionnelle",
"link": "/voie-lyonnaise-1#quai-claude-bernard"
"link": "/voie-lyonnaise-1#quai-claude-bernard",
"quality": "satisfactory"
},
"geometry": {
"type": "LineString",
Expand Down Expand Up @@ -589,7 +605,8 @@
"name": "Avenue Leclerc",
"status": "postponed",
"type": "voie-bus",
"link": "/voie-lyonnaise-1#avenue-général-leclerc"
"link": "/voie-lyonnaise-1#avenue-général-leclerc",
"quality": "satisfactory"
},
"geometry": {
"type": "LineString",
Expand Down Expand Up @@ -617,7 +634,8 @@
"status": "done",
"doneAt": "31/12/2019",
"type": "bidirectionnelle",
"link": "/voie-lyonnaise-1#avenue-général-leclerc"
"link": "/voie-lyonnaise-1#avenue-général-leclerc",
"quality": "satisfactory"
},
"geometry": {
"type": "LineString",
Expand All @@ -634,7 +652,8 @@
"name": "Tony Garnier Ouest",
"status": "wip",
"type": "bidirectionnelle",
"link": "/voie-lyonnaise-1#halle-tony-garnier-à-st-fons-centre"
"link": "/voie-lyonnaise-1#halle-tony-garnier-à-st-fons-centre",
"quality": "satisfactory"
},
"geometry": {
"type": "LineString",
Expand Down Expand Up @@ -665,7 +684,8 @@
"name": "Tony Garnier Est",
"status": "wip",
"type": "bidirectionnelle",
"link": "/voie-lyonnaise-1#halle-tony-garnier-à-st-fons-centre"
"link": "/voie-lyonnaise-1#halle-tony-garnier-à-st-fons-centre",
"quality": "satisfactory"
},
"geometry": {
"type": "LineString",
Expand All @@ -690,7 +710,8 @@
"name": "St-Jean-de-Dieu - Sampaix - Sembat",
"status": "planned",
"type": "bidirectionnelle",
"link": "/voie-lyonnaise-1#halle-tony-garnier-à-st-fons-centre"
"link": "/voie-lyonnaise-1#halle-tony-garnier-à-st-fons-centre",
"quality": "satisfactory"
},
"geometry": {
"type": "LineString",
Expand Down Expand Up @@ -729,7 +750,8 @@
"name": "St-Fons Ouest",
"status": "planned",
"type": "bidirectionnelle",
"link": "/voie-lyonnaise-1#halle-tony-garnier-à-st-fons-centre"
"link": "/voie-lyonnaise-1#halle-tony-garnier-à-st-fons-centre",
"quality": "satisfactory"
},
"geometry": {
"type": "LineString",
Expand Down
Loading

0 comments on commit ef85c3e

Please sign in to comment.