Task translations #2020
Merged
Task translations #2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
indigo_api/models/tasks.py
Outdated
| CANCELLED = 'cancelled' | ||
| DONE = 'done' | ||
| BLOCKED = 'blocked' | ||
| OPEN = __('open') |
There was a problem hiding this comment.
these are used in the db and must not be translated, otherwise the codes in the db will differ
indigo_api/models/tasks.py
Outdated
|
|
||
| objects = TaskManager.from_queryset(TaskQuerySet)() | ||
|
|
||
| title = models.CharField(max_length=256, null=False, blank=False) | ||
| title = models.CharField(__('title'), max_length=256, null=False, blank=False) | ||
| description = models.TextField(null=True, blank=True) |
actlikewill
commented
Mar 7, 2024
indigo_api/models/tasks.py
Outdated
| @@ -4,7 +4,7 @@ | |||
|
|
|||
| from actstream import action | |||
| from django.core.files.uploadedfile import UploadedFile | |||
| from django.utils.translation import gettext_lazy as __, gettext as _ | |||
| from django.utils.translation import ugettext_lazy as __, ugettext as _ | |||
There was a problem hiding this comment.
@longhotsummer some other strings are marked with ugettext, instead of ugettext_lazy. Is there a reason?
actlikewill
commented
Mar 7, 2024
indigo_api/models/tasks.py
Outdated
| locality = models.ForeignKey('indigo_api.Locality', verbose_name=__('locality'), related_name='tasks', null=True, blank=True, on_delete=models.CASCADE) | ||
| work = models.ForeignKey('indigo_api.Work', verbose_name=__('work'), related_name='tasks', null=True, blank=True, on_delete=models.CASCADE) | ||
| document = models.ForeignKey('indigo_api.Document', verbose_name=__('document'), related_name='tasks', null=True, blank=True, on_delete=models.CASCADE) | ||
| timeline_date = models.DateField(__('timeline date'), null=True, blank=True, help_text=__("A date on the timeline of work-related tasks, e.g. the date at which an amendment should be applied.")) | ||
|
|
||
| state = FSMField(default=OPEN) |
There was a problem hiding this comment.
@longhotsummer also there is this guy
There was a problem hiding this comment.
treat it like a CharField, so just add the name at the start before default
longhotsummer
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
task translations