enable italicisation of portion #2312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
references requires laws-africa/docpipe#19 |
longhotsummer
previously approved these changes
Jan 13, 2025
indigo_app/static/javascript/indigo/views/document_references.js
Outdated
Show resolved
Hide resolved
indigo_app/static/javascript/indigo/views/document_defined_terms.js
Outdated
Show resolved
Hide resolved
indigo_app/static/javascript/indigo/views/document_italics_terms.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Greg Kempe <greg@kempe.net>
Co-authored-by: Greg Kempe <greg@kempe.net>
indigo/analysis/terms/base.py
Outdated
| def fix_terms_in_document(self, document): | ||
| """ Do everything other than guessing at defined terms in a Document. | ||
| Run this before saving an updated document when a portion was edited separately. | ||
| def link_terms_in_provision(self, document): |
There was a problem hiding this comment.
Minor: this method name doesn't make senses in this context, because there's no provision information. link_terms_in_document or find_term_usages_in_document or something would make more sense to me.
| @@ -109,7 +109,7 @@ <h5 class="main-header-title"> | |||
| </div> | |||
|
|
|||
| {% include "indigo_api/document/_revisions.html" %} | |||
| {% include "indigo_api/document/_defined_terms.html" %} | |||
| {% include "indigo_api/document/_defined_terms.html" with provision_eid=provision_eid %} | |||
There was a problem hiding this comment.
the with is unnecessary, the context always passed to the included template
Co-authored-by: Greg Kempe <greg@kempe.net>
Co-authored-by: Greg Kempe <greg@kempe.net>
longhotsummer
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if we're happy with this approach here, we can attempt to follow it for the sentence caser and more importantly the pit differ