-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provision editing permissions, links #2331
Conversation
I think it would make more sense to have the links in the same line as the current document links, like the reader mode links. Perhaps before the reader link? |
I thought you might say that 😅 it'll involve a change to the Reader at https://github.com/laws-africa/indigo-la-tradition/blob/master/indigo_la_tradition/js/components/DocumentReader/index.ts#L172 but I think you're right :) |
Ugh. lol. Why not add a named block to |
oops too late I already tweaked the query selector, PR incoming 🙈 |
{% if provision_eid %} | ||
<li class="breadcrumb-item"><a href="{% url 'choose_document_provision' document.pk %}">{{ provision_eid }}</a></li> | ||
{% if provision_eid or perms.indigo_api.publish_document %} | ||
<li class="breadcrumb-item"><i class="fas fa-list published"></i> <a href="{% url 'choose_document_provision' document.pk %}">{% trans "Provision editor" %}</a></li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally think that the eid is a useful part of the breadcrumb, because it's only otherwise visible in the url. But up to you.
I assumed there was a reason we did this differently than all our other overrides and I didn't want to rush into getting rid of the whole ReaderWorkOverviewShim, but I do now think this would be safe to do! I'll update the two PRs quick |
To do: