fix: Logo enlarges on return to the home page. #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for bejewelled-pegasus-b0ce81 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: abhishek <abhishek4code@gmail.com>
abbi4code
force-pushed
the
bug/logo-enlarge-on-homepage
branch
from
5ad4e18
to
1a3faa8
Compare
|
@abbi4code, Let's discuss this during the website call on Monday at 5:30 PM IST (7:00 AM CT). Please consider adding it as an agenda item to the meeting minutes || meeting link. |
Aviral0702
reviewed
Sep 23, 2024
layouts/partials/navbar.html
Outdated
| @@ -6,7 +6,7 @@ | |||
| <a class="navbar-brand" href="/"> | |||
| <span class="navbar-brand__logo navbar-logo"> | |||
| {{ $svg := resources.Get "icons/logo.svg" }} | |||
| <img class="footer-logo" src="{{ $svg.Permalink }}" alt="logo" /> | |||
| <img class="footer-logo" id="navbar-brand_logo" src="{{ $svg.Permalink }}" alt="logo" /> | |||
There was a problem hiding this comment.
Rename id to be id = "navbar-brand-logo" to maintain consistency.
LGTM!
There was a problem hiding this comment.
Thanks! I've made the changes to rename the id to navbar-brand-logo for consistency.
Signed-off-by: abhishek <abhishek4code@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
This PR fixes #222
##Fixes
idattribute to the navbar logo image with the valuenavbar-brand_logo.navbar-brand_logo, the modal will not open.Signed commits