-
Notifications
You must be signed in to change notification settings - Fork 153
fix(footer): Prevent unexpected input expansion by removing width change on focus #881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -263,17 +263,11 @@ | |
| border-radius: 0.5rem; | ||
| outline: none; | ||
| color: $white; | ||
| transition: border-color 0.2s ease; | ||
|
|
||
| &:focus { | ||
| padding: 1rem; | ||
| margin-right: 0.25rem; | ||
| width: 24rem; | ||
| height: 3.5rem; | ||
| border: 0.5px solid $white; | ||
| background: transparent; | ||
| border-radius: 0.5rem; | ||
| border: 1px solid $white; | ||
| outline-width: 0; | ||
| color: $white; | ||
| } | ||
| } | ||
|
|
||
|
|
@@ -286,6 +280,35 @@ | |
| border: none; | ||
| } | ||
|
|
||
| .newsletter-container { | ||
| display: flex; | ||
| align-items: flex-start; | ||
| flex-direction: column; | ||
| } | ||
|
|
||
| .newsletter-input-row { | ||
| display: flex; | ||
| align-items: center; | ||
| } | ||
|
|
||
| .newsletter-message { | ||
| margin-top: 0.5rem; | ||
| font-size: 0.9rem; | ||
| min-height: 1.5rem; | ||
| } | ||
|
|
||
| .visually-hidden { | ||
| position: absolute; | ||
| width: 1px; | ||
| height: 1px; | ||
| margin: -1px; | ||
| padding: 0; | ||
| overflow: hidden; | ||
| clip: rect(0, 0, 0, 0); | ||
| white-space: nowrap; | ||
| border: 0; | ||
| } | ||
|
Comment on lines
+300
to
+310
|
||
|
|
||
| .footer-hr { | ||
| width: 100%; | ||
| color: $white; | ||
|
|
@@ -587,4 +610,4 @@ | |
| .footer-company{ | ||
| margin-left: 5px; | ||
| } | ||
| } | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These CSS classes (newsletter-container, newsletter-input-row, and newsletter-message) are not used anywhere in the codebase. They appear to be intended for restructuring the newsletter form in layouts/partials/footer.html, but the HTML template has not been updated to use them. This introduces dead code that will not be utilized. Consider either removing these unused classes or ensuring the corresponding HTML changes are included in this PR to maintain code consistency and avoid confusion.