-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update main.go #289
base: master
Are you sure you want to change the base?
Update main.go #289
Conversation
Signed-off-by: Shivang Shandilya <101946115+ShivangShandilya@users.noreply.github.com>
Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ShivangShandilya Thanks for your PR, I left a comment.
Thanks, @ShivangShandilya, could you help with the Go lint issue too here? |
Can you elaborate on this?? |
I personally would favor usage of |
Description
This PR fixes #288
Notes for Reviewers
log.Fatal() has been replaced with log.Error()
Signed commits