Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix CI] Add Label Commenter #355

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

sandramsc
Copy link
Member

Description

This PR fixes #354

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Updated the label-commenter.yml file to enable automated commenter in the repo

Signed-off-by: Sandra Ashipala <sandraashipala@gmail.com>
Updated the label-commenter-config.yml file to enable automated commenter in the repo

Signed-off-by: Sandra Ashipala <sandraashipala@gmail.com>
Copy link

netlify bot commented Dec 8, 2023

Website preview ready!

Name Link
🔨 Latest commit e8016e3
🔍 Latest deploy log https://app.netlify.com/sites/getnighthawk/deploys/657aab60e103910008fd9ce3
😎 Deploy Preview https://deploy-preview-355--getnighthawk.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@Yashsharma1911 Yashsharma1911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines +34 to +42
- name: component/ui
labeled:
issue:
body: This issue has been labeled with 'component/ui'. 🧰 Here are docs on [Contributing to Meshery UI](https://docs.meshery.io/project/contributing/contributing-ui). 🎨 Here is the [Meshery UI Figma File](https://www.figma.com/file/SMP3zxOjZztdOLtgN4dS2W/Meshery-UI?node-id=4%3A0) File. Lastly, here are docs on [Contributing to Meshery's End-to-End Tests Using Cypress](https://docs.meshery.io/project/contributing/contributing-cypress).
action: open
pr:
body: This PR has been labeled with 'component/ui'. 🧰 Here are docs on [Contributing to Meshery UI](https://docs.meshery.io/project/contributing/contributing-ui). 🎨 Here is the [Meshery UI Figma File](https://www.figma.com/file/SMP3zxOjZztdOLtgN4dS2W/Meshery-UI?node-id=4%3A0) File. Lastly, here are docs on [Contributing to Meshery's End-to-End Tests Using Cypress](https://docs.meshery.io/project/contributing/contributing-cypress)
action: open
- name: component/mesheryctl
Copy link
Member

@Yashsharma1911 Yashsharma1911 Feb 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sandramsc why we need lablel component/ui and component/messheryctl these are related to meshery we may want label kind/chore to get auto assigned though which mostly will be for documentation

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yashsharma1911 these are comments that occur when a PR is labeled with any of those identified here.

When such a label is applied to an open PR, this workflow is supposed to then add some helpful information with context specific to the area of code that has been changed.

Comment on lines +34 to +42
- name: component/ui
labeled:
issue:
body: This issue has been labeled with 'component/ui'. 🧰 Here are docs on [Contributing to Meshery UI](https://docs.meshery.io/project/contributing/contributing-ui). 🎨 Here is the [Meshery UI Figma File](https://www.figma.com/file/SMP3zxOjZztdOLtgN4dS2W/Meshery-UI?node-id=4%3A0) File. Lastly, here are docs on [Contributing to Meshery's End-to-End Tests Using Cypress](https://docs.meshery.io/project/contributing/contributing-cypress).
action: open
pr:
body: This PR has been labeled with 'component/ui'. 🧰 Here are docs on [Contributing to Meshery UI](https://docs.meshery.io/project/contributing/contributing-ui). 🎨 Here is the [Meshery UI Figma File](https://www.figma.com/file/SMP3zxOjZztdOLtgN4dS2W/Meshery-UI?node-id=4%3A0) File. Lastly, here are docs on [Contributing to Meshery's End-to-End Tests Using Cypress](https://docs.meshery.io/project/contributing/contributing-cypress)
action: open
- name: component/mesheryctl
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yashsharma1911 these are comments that occur when a PR is labeled with any of those identified here.

When such a label is applied to an open PR, this workflow is supposed to then add some helpful information with context specific to the area of code that has been changed.

- name: component/ui
labeled:
issue:
body: This issue has been labeled with 'component/ui'. 🧰 Here are docs on [Contributing to Meshery UI](https://docs.meshery.io/project/contributing/contributing-ui). 🎨 Here is the [Meshery UI Figma File](https://www.figma.com/file/SMP3zxOjZztdOLtgN4dS2W/Meshery-UI?node-id=4%3A0) File. Lastly, here are docs on [Contributing to Meshery's End-to-End Tests Using Cypress](https://docs.meshery.io/project/contributing/contributing-cypress).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that we're moving away from Cypress to Playwright, we'll either want to exclude this link in the comment now, or include it, but create an issue to track the need to updated it when the Playwright version of the contrib instructions are available. Either way, we need one or two new issues created:

  1. Create a Playwright contrib doc.
  2. Update this link.

@MarioArriaga92

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[CI] Add Label Commenter
3 participants