Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: updated to timsrust 0.4.0 #152

Merged
merged 3 commits into from
Sep 10, 2024

Conversation

sander-willems-bruker
Copy link
Contributor

Updated to timsrust 0.4.0
Major differences:

  • Much improved error handling / propagation
  • Exposure of parameters for Bruker spectrum reading through the config.json
  "bruker_spectrum_processor": {
    "smoothing_window": 1, 
    "centroiding_window": 1,
    "calibration_tolerance": 0.1,
    "calibrate": false,
    "dia_strategy": {"Quadrupole": {"Even": 1}}
  }
  • All parameters should be considered experimental and are use at your own caution. Defaults are generally acceptable, although some settings yield (signifcantly) better or worse results.
  • calibrate only is sensible for dda data. Works best if there are many precursors (i.e. long gradient).
  • calibration tolerance roughly defines the maximum possible mz difference before/after calibration.
  • smoothing_window defines how adjacent tof indices are smoother.
  • centroiding_window sets the minimum tof difference between two detections, i.e. relates to TOF resolution in combination with smoothing_window.
  • dia_strategy allows to control how dia windows or even frames are translated to DDA-like spectra that are searchable with Sage. Options
    • Quadrupole vs. Window: use the whole frame or just that portion where the quadrupole is not changing
    • None, Even(usize), UniformMobility((f64, f64)), UniformScan((usize, usize)),: The method to split up scans. Even splits its up in an equal partition, whereas the Uniform methods allow finegrained control how many scans are aggregated.

There is room for improvement on how this is implemented on Sage, most is roughly copy-paste at the moment. Feel free to suggest an alternative/better way.

@sander-willems-bruker sander-willems-bruker marked this pull request as ready for review September 2, 2024 09:51
@lazear
Copy link
Owner

lazear commented Sep 3, 2024

Looks good to me! Could you rebase your branch onto the latest Sage master branch? Looks like there's a conflict in the Cargo.lock files (had to be updated to compile with Rust 1.8.0)

@sander-willems-bruker
Copy link
Contributor Author

Looks good to me! Could you rebase your branch onto the latest Sage master branch? Looks like there's a conflict in the Cargo.lock files (had to be updated to compile with Rust 1.8.0)

Done!

@lazear lazear merged commit 445f5ab into lazear:master Sep 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants