-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CDL-Based Sequence Documentation #249
Conversation
- Recursively evaluate each term that resolves into an expression. - This avoids protecting each term by () — which creates other issues. - Returned arrays are stringified.
- Handle if else expressions with JS ? : construct
b390d9d
to
66e4325
Compare
605e959
to
1c0dc9c
Compare
1c0dc9c
to
e200aba
Compare
@mwetter This is ready for review. (I've added the option to include tables of parameters, inputs and outputs in the documentation) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great.
A few comments:
In the generated Word document, there is a text
A staging matrix staEqu is required as a parameter. See the documentation of Buildings.Templates.Plants.Controls.StagingRotation.EquipmentEnable for the associated definition and requirements
Should this be a hyperlink to simulationresearch.lbl.gov/modelica/vXXX (based on theuses
statement)?
When listing the parameters it would be good to reuse the tabs and groups from the Modelica annotation.
From a section, such as https://docs.google.com/document/d/1pceD7fS5jnLZ47zsf1FBODqVHPtaF3wD/edit#bookmark=id.2nusc19
how does one know what block (with the I/O and parameter listing in the Appendix) is used? Should there be a hyperlink so people can make the association?
The parameter listing does not show defaults, min and max. I assume this is intentional.
@mwetter Thanks for looking into this. The block In dfb3a9b, I've added the tabs and groups to the parameter tables as you suggested. At the end of each section, there is a new subsection added that provides the link to the block variables and the block name. In the example you give, there are subsections already included in the documentation of the block (with The parameter listing does not show defaults, min and max. This is as intended, because there is a unique table for each block definition, not for each block instance. Since defaults, min and max may be overridden at instanciation, providing these values would require one table for each instance. |
This addresses #235.
The requirements and technical debts are described in this document: https://docs.google.com/document/d/1qObow0A18hq4nfmZY8vdcpYV-vOMIzkB5HJ4aLMmw-Q/edit?usp=sharing
To illustrate the new feature, the document at https://docs.google.com/document/d/12pnP6-vSE7AVGYGQPzi0PMyJVeeLhj2u/edit?usp=drive_link&ouid=100056680517301634140&rtpof=true&sd=true is created by
node ../modelica-json/app.js -f Buildings/Templates/Plants/Controls/HeatPumps/Validation/AirToWater.mo -o doc
with commit bcc98069af of MBL (from private repo),Edit > Links > (Ctrl+A to select all source files) Save picture in document
,The same documentation with additional tables describing all parameters and I/O variables for each block is available at https://docs.google.com/document/d/100ZfL4T0VL5IzPjI2eqrEfuVhKuKlAxA/edit?usp=sharing&ouid=100056680517301634140&rtpof=true&sd=true
It is created by running
node ../modelica-json/app.js -f Buildings/Templates/Plants/Controls/HeatPumps/Validation/AirToWater.mo -o doc+
on the same commit of MBL, and using the same steps as above in MS Word.