[WIP] Touch support #143
[WIP] Touch support #143
Conversation
| @@ -526,6 +526,100 @@ static const struct wl_keyboard_listener wayland_keyboard_listener = { | |||
| .repeat_info = wayland_keyboard_repeat_info, | |||
| }; | |||
|
|
|||
| static void wayland_touch_down(void *data, struct wl_touch *wl_touch, | |||
There was a problem hiding this comment.
The indentation is a bit inconsistent with the rest of the file.
Could you please run clang-format on the lines you've added?
| return; | ||
| } | ||
| int key = KEY_ENTER; | ||
| if (time - self->touches[id].start_time > 200) { |
There was a problem hiding this comment.
Maybe define this 200 as a constant with a proper name at the top of this function?
| } | ||
|
|
||
| static int32_t y_offset_to_line_offset(int32_t y_offset) { | ||
| static const int32_t line_height = 20; |
There was a problem hiding this comment.
So, this "20" is some kind of hard-coded sensitivity?
It is fine for now but maybe add a TODO comment like "TODO: make sensitivity parametrizable"
|
Moving discussion from #156 here, and will close according to authors responses. @chayleaf, do you plan continuing work on this? I figured your PR was exactly that, a request to pull this into code base, and @lbonn has already expressed he would merge as an initial iteration. Though it was not clear from this thread that this does not work as you state in 156... yes it's not perfect, but from my initial testing on two devices suffices to avoid having to replace rofi. There are some minor bugs, but at least it's functional and for me it greatly helps. Better this than having to look for another launcher. If you can provide some feedback, I'm happy to help, or close the other PR -- just let me know :) PS: duly noted regarding history/authorship, will do, thanks. |
I am daily driving this branch on my phone, which is why I know it's not ready to merge yet. I do want to fix the issues when I have the time.
There is a reason this is a draft PR, draft PRs aren't ready for merging For now, I recommend you to apply these patches locally. |
| if (time - self->touches[id].start_time > 200) { | ||
| key = KEY_ESC; | ||
| } | ||
| nk_bindings_seat_handle_key(wayland->bindings_seat, NULL, |
There was a problem hiding this comment.
on some rofi launches, this doesn't work (i.e. if it doesn't work, it won't magically fix itself if you click multiple times). TODO figure out why
See #122
This implements touch support in the following way:
-click-to-exitwould work, then this would be unnecessary)This is obviously not ideal, so I'd like some feedback on how a proper implementation should look like
Maybe programmable gesture support should be added? this would be useful for e.g. mode switching. I have no idea how the config for that should look though.