Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented visit_Return for freeing variables #2412

Merged
merged 2 commits into from
Nov 9, 2023

Conversation

anutosh491
Copy link
Collaborator

@anutosh491 anutosh491 commented Nov 9, 2023

Fixes #2411

We need to take care of two things

  1. If we have a function returning something, we would like to free all local basic variables before returning
  2. As we are retuning the _lpython_return_variable I don't think so we need to free that.

Now we would have something like

                                    (SubroutineCall
                                        2 basic_free_stack
                                        2 basic_free_stack
                                        [((Var 3 stack0))]
                                        ()
                                    )
                                    (SubroutineCall
                                        2 basic_free_stack
                                        2 basic_free_stack
                                        [((Var 3 stack1))]
                                        ()
                                    )
                                    (Return)]
                                    (Var 3 _lpython_return_variable)

Where stack0 and stack1 might be some local variables used inside the function, then followed by the Return statement.

Copy link
Collaborator

@Thirumalai-Shaktivel Thirumalai-Shaktivel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine, thank you!

src/libasr/pass/replace_symbolic.cpp Outdated Show resolved Hide resolved
@certik
Copy link
Contributor

certik commented Nov 9, 2023

Can you add a test?

Why not calling the function to subroutine pass?

Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine.

@certik
Copy link
Contributor

certik commented Nov 9, 2023

This is fixing memory leaks.

@certik certik merged commit f0b2a49 into lcompilers:main Nov 9, 2023
13 checks passed
@anutosh491 anutosh491 deleted the visit_return branch November 10, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Call basic_free_stack before return statement
3 participants