Rename LFortran namespace to LCompilers#534
Rename LFortran namespace to LCompilers#534Thirumalai-Shaktivel wants to merge 7 commits intolcompilers:mainfrom
LFortran namespace to LCompilers#534Conversation
|
Let's first sync libasr with LFortran / LPython, then do this change in both projects at once, otherwise it will be quite hard to sync. |
$ ctest
Test project /home/thirumalai/Open_Source/lpython
Start 1: test_stacktrace
1/2 Test #1: test_stacktrace .................. Passed 0.92 sec
Start 2: test_lpython
2/2 Test #2: test_lpython .....................***Failed 0.15 sec
50% tests passed, 1 tests failed out of 2
Total Test time (real) = 1.08 sec
The following tests FAILED:
2 - test_lpython (Failed)
Errors while running CTest
Output from these tests are in: /home/thirumalai/Open_Source/lpython/Testing/Temporary/LastTest.log
Use "--rerun-failed --output-on-failure" to re-run the failed cases verbosely.@certik, How to resolve this error? |
|
You have to see what the error is by executing |
$ ./src/lpython/tests/test_lpython
[doctest] doctest version is "2.4.8"
[doctest] run with "--help" for options
===============================================================================
/home/thirumalai/Open_Source/lpython/src/lpython/tests/test_error_rendering.cpp:59:
TEST CASE: Error Render: primary/secondary labels, single line
/home/thirumalai/Open_Source/lpython/src/lpython/tests/test_error_rendering.cpp:94: ERROR: CHECK( out == ref ) is NOT correct!
values: CHECK( semantic error: Error with label no message
--> input:1:5
|
1 | One line text
| ^^^^
== semantic error: Error with label no message
--> input:1:5
|
1 | One line text
| ^^^^
)
===============================================================================
[doctest] test cases: 37 | 36 passed | 1 failed | 0 skipped
[doctest] assertions: 210 | 209 passed | 1 failed |
[doctest] Status: FAILURE!Both the strings seems similar! |
|
Is there an extra |
|
I think the extra |
|
Is this on Windows? I wonder if it is some CR / LF issue. |
|
Nah. It fails on Linux! Yup, It might be CR / LF issue. |
|
It's in the file src/lpython/tests/CMakeLists.txt, you can try to debug it. However, I would recommend to split this into smaller changes and just get one smaller change at a time. And make sure to submit a PR both to LPython and LFortran, so that we can keep the libasr synchronized. |
61b1ea1 to
f198202
Compare
|
If anything else to be modified, do let me know. |
70f4696 to
b7340f1
Compare
|
We need to sync ASR first, otherwise it will be a lot of work I think. |
b7340f1 to
bb2e4fe
Compare
|
This PR is ready! |
|
Yes, we should do it, but we need to do this both in LFortran and LPython at the same time. |
|
Cool, I will submit a PR with same changes there. |
cf81f9c to
c7c0e88
Compare
LCompilers in libasr LCompilers::LPython in Tokenizer, Parser, Python_AST_to_ASR, ...
c7c0e88 to
7c2c08d
Compare
| !5 = !{null} | ||
| !6 = !DILocation(line: 9, column: 1, scope: !3) | ||
| !7 = distinct !DISubprogram(name: "main0", scope: !1, file: !1, line: 1, type: !4, flags: DIFlagPrototyped, spFlags: DISPFlagDefinition, unit: !0, retainedNodes: !2) | ||
| !2 = distinct !DISubprogram(name: "_lpython_main_program", scope: !1, file: !1, line: 1, type: !3, flags: DIFlagPrototyped, spFlags: DISPFlagDefinition, unit: !0, retainedNodes: !5) |
There was a problem hiding this comment.
These changes are made using LLVM 15. But, CI uses LLVM 11. So, the failure.
|
@certik, This PR is ready for final review. |
7f79f76 to
6516987
Compare
|
I'm spitting this PR into different PR's. |
6516987 to
e5e9f4c
Compare
Closes: #403
Related: #560