Fixing Bug Related to ZapdosReactions Action and Updating MOOSE Submodule #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@csdechant Can you push a new commit here updating the submodule again? |
|
I want to use this event to check some status on our CI config. |
csdechant
force-pushed
the
addZapdosReactions_fixes_and_MOOSE_update
branch
from
c1892a9 to
6038a6b
Compare
|
Just did a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will do the following:
track_rates = trueis set, an error stating duplicate variables will occur. This is because of line 279 in fileAddZapdosReactions.Cwas not needed due to line 286 (i.e.,_problem->addAuxVariablewas called twice for the same operation). Removing line 279 fixes the error and results in the expected outcome.