Skip to content

fix nil error on PR open #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cosmicbuffalo wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix nil error on PR open #122

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ecb811
fix nil error on PR open
cosmicbuffalo Sep 14, 2024
73a8bd7
fix another line
cosmicbuffalo Sep 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lua/litee/gh/pr/marshal.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ local function marshal_thread_node(use_original)
line = node.thread["originalLine"]
end
local root_comment = node["children"][1]["comment"]
if root_comment["originalCommit"] ~= vim.NIL then
if root_comment["originalCommit"] ~= nil and root_comment["originalCommit"]["oid"] ~= nil then
detail = string.sub(root_comment["originalCommit"]["oid"], 1, 8)
detail = "@ " .. detail
end
Expand All @@ -73,7 +73,7 @@ local function marshal_thread_node(use_original)
line = node.thread["line"]
end
local root_comment = node["children"][1]["comment"]
if root_comment["originalCommit"] ~= vim.NIL then
if root_comment["originalCommit"] ~= nil and root_comment["originalCommit"]["oid"] ~= nil then
detail = string.sub(root_comment["originalCommit"]["oid"], 1, 8)
detail = "@ " .. detail
end
Expand Down