Skip to content

Use git config ssh remote url to account for custom ssh aliases #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
senyc wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Use git config ssh remote url to account for custom ssh aliases #125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e1776b8
feat: default to git config remote, as this takes into account differ…
senyc Sep 23, 2024
3901878
fix: correct accidental inclusion of newline in get_git_remote
senyc Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions lua/litee/gh/gitcli/init.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,4 +138,12 @@ function M.git_reset_hard(remote, branch)
return out
end

function M.get_git_remote()
local out = git_exec([[git config --get remote.origin.url]])
if out == nil then
return nil
end
return out:gsub("\n", "")
end

return M
9 changes: 8 additions & 1 deletion lua/litee/gh/pr/state.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -529,7 +529,14 @@ function M.get_pr_remote_url()
if protocol == 'https' then
remote_url = M.pull_state.pr_raw['head']['repo']['clone_url']
else
remote_url = M.pull_state.pr_raw['head']['repo']['ssh_url']
-- Defaults to git remote if set
local git_origin_url = gitcli.get_git_remote()
if git_origin_url ~= nil then
remote_url = git_origin_url
else
remote_url = M.pull_state.pr_raw['head']['repo']['ssh_url']
end

end

return remote_url
Expand Down