Skip to content

implement niri WM service, fix app switcher crash when no app is open #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
p00f wants to merge 2 commits into
base: main
Choose a base branch
from
Open

implement niri WM service, fix app switcher crash when no app is open #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
033894c
implement niri WM service, fix app switcher crash when no app is open
p00f Oct 11, 2025
e39bce7
fix glib warnings
p00f Oct 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,4 @@ way-shell
way-sh/way-sh
gresources.c
gresources.h
/.cache/
6 changes: 4 additions & 2 deletions src/activities/activities.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,8 +404,10 @@ static void activities_init_layout(Activities *self) {
gtk_widget_set_halign(GTK_WIDGET(self->search_entry), GTK_ALIGN_CENTER);
gtk_widget_set_size_request(GTK_WIDGET(self->search_entry), 480, 120);

gtk_entry_set_placeholder_text(
GTK_ENTRY(self->search_entry),
// gtk_entry_set_placeholder_text(
// GTK_ENTRY(self->search_entry),
gtk_search_entry_set_placeholder_text( // fixes (way-shell:13960): GLib-GObject-CRITICAL **: 12:12:03.013: invalid cast from 'GtkSearchEntry' to 'GtkEntry'
self->search_entry,
"Search Applications...ctrl-g for next, ctrl-s-g for prev");

// wire into search-changed signal for GtkSearchEntry
Expand Down
7 changes: 7 additions & 0 deletions src/app_switcher/app_switcher.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,6 +419,13 @@ void app_switcher_activate(AdwApplication *app, gpointer user_data) {
void app_switcher_show(AppSwitcher *self) {
g_debug("app_switcher.c:app_switcher_show called");

// fixes crash when app switcher is invoked without any apps open
if (self->widget_n == 0) {
g_debug("app_switcher.c:app_switcher_show no widgets available, hiding");
app_switcher_hide(self);
return;
}

if (self->widget_n > 1) {
if (self->select_alternative_app)
app_switcher_focus_widget_at_index(self, 1);
Expand Down
5 changes: 4 additions & 1 deletion src/panel/message_tray/message_tray.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@

#include "./notifications/notifications_list.h"
#include "calendar/calendar.h"
#include "glib-object.h"
#include "gtk/gtk.h"

enum signals {
Expand Down Expand Up @@ -194,6 +195,7 @@ static void message_tray_init_layout(MessageTray *self) {

// get GdkSurface from self->win
GtkNative *native = gtk_widget_get_native(GTK_WIDGET(self->win));
gtk_widget_realize(GTK_WIDGET(native)); // fixes (way-shell:15127): GLib-GObject-CRITICAL **: 12:18:35.939: invalid (NULL) pointer instance
GdkSurface *surface = gtk_native_get_surface(native);
g_signal_connect(surface, "layout", G_CALLBACK(on_layout_changed), self);

Expand Down Expand Up @@ -273,7 +275,8 @@ static void message_tray_init(MessageTray *self) {
// create dependent widgets
self->notifications_list = g_object_new(NOTIFICATIONS_LIST_TYPE, NULL);

g_object_unref(self->calendar);
// g_object_unref(self->calendar);
g_clear_object(&self->calendar); // fixes (way-shell:14434): GLib-GObject-CRITICAL **: 12:15:40.810: g_object_unref: assertion 'G_IS_OBJECT (object)' failed

// setup the layout
message_tray_init_layout(self);
Expand Down
2 changes: 1 addition & 1 deletion src/services/wayland/wlr-foreign-toplevel-management-unstable-v1.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* Generated by wayland-scanner 1.23.0 */
/* Generated by wayland-scanner 1.24.0 */

/*
* Copyright © 2018 Ilia Bozhinov
Expand Down
2 changes: 1 addition & 1 deletion src/services/wayland/wlr-foreign-toplevel-management-unstable-v1.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* Generated by wayland-scanner 1.23.0 */
/* Generated by wayland-scanner 1.24.0 */

#ifndef WLR_FOREIGN_TOPLEVEL_MANAGEMENT_UNSTABLE_V1_CLIENT_PROTOCOL_H
#define WLR_FOREIGN_TOPLEVEL_MANAGEMENT_UNSTABLE_V1_CLIENT_PROTOCOL_H
Expand Down
2 changes: 1 addition & 1 deletion src/services/wayland/wlr-gamma-control-unstable-v1.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* Generated by wayland-scanner 1.23.0 */
/* Generated by wayland-scanner 1.24.0 */

/*
* Copyright © 2015 Giulio camuffo
Expand Down
2 changes: 1 addition & 1 deletion src/services/wayland/wlr-gamma-control-unstable-v1.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* Generated by wayland-scanner 1.23.0 */
/* Generated by wayland-scanner 1.24.0 */

#ifndef WLR_GAMMA_CONTROL_UNSTABLE_V1_CLIENT_PROTOCOL_H
#define WLR_GAMMA_CONTROL_UNSTABLE_V1_CLIENT_PROTOCOL_H
Expand Down
Loading