Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct implementation for the entity remove event handler #10565

Merged
merged 1 commit into from
Jan 5, 2025
Merged

Correct implementation for the entity remove event handler #10565

merged 1 commit into from
Jan 5, 2025

Conversation

Thodor12
Copy link
Contributor

Changes proposed in this pull request

  • Redo incorrect call to event handler in several small fixes #10558
  • Modified the removal event to not include citizen data as this is null at the point of event creation, using citizen ID instead.

Testing

  • Yes I tested this before submitting it.
  • I also did a multiplayer test.

Review please

@Raycoms Raycoms merged commit ec6eccf into version/main Jan 5, 2025
5 checks passed
@Raycoms Raycoms deleted the fix/event_nullpointer branch January 5, 2025 11:16
Raycoms added a commit that referenced this pull request Jan 20, 2025
@Raycoms
Correct implementation for the event handler (#10565)
303f4c8 
Correct implementation for the entity remove event handler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@someaddons someaddons someaddons approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Thodor12 @someaddons @Raycoms