Marius9595/fix compilation #54
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This pull request includes several changes to improve the handling of monads in the @leanmind/monads package, specifically focusing on error handling in the Try monad and updating the build process.
Build Process Updates:
package.json: Updated the main and module fields to point to dist/cjs/index.js and dist/esm/index.js respectively. Modified the build scripts to compile both CommonJS and ES modules. [1] [2]
Try Monad Error Handling:
src/try/try.ts: Updated the from method to ensure that a Failure instance is always created with an Error object. Modified the Failure class to use a default type of Error. Removed the static NO_ERROR_PROVIDED instance. [1] [2] [3]
src/try/try.test.ts: Adjusted the test cases to reflect the changes in error handling, ensuring that Failure instances are created with an Error object.
Added/updated tests?
We encourage you to keep the quality of the code by creating test.
have not been included
[optional] What gif best describes this PR or how it makes you feel?