Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CID-2940 Use 5 max attempts for retrying establishing connection #57

Merged
merged 5 commits into from
Dec 16, 2024
Merged

CID-2940 Use 5 max attempts for retrying establishing connection #57

merged 5 commits into from
Dec 16, 2024

Conversation

geoandri
Copy link
Contributor

🛠 Changes made

With this PR we limit the maximum attempts on re establishing the websocket connections to 3

✨ Type of change

Please delete the options that are not relevant.

  • New feature (non-breaking change which adds functionality)

🧪 How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

  • Unit tests
  • Manual tests

🏎 Checklist:

  • My code follows the style guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • Any dependent changes have been merged and published in downstream modules
  • My commit message clearly reflects the changes made
  • Assigned the appropriate labels (version, PR type, etc.)

@geoandri geoandri requested a review from a team as a code owner December 11, 2024 08:01
@geoandri geoandri added the chore label Dec 11, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 11, 2024 •
edited
Loading

LeanIX GitHub Agent Code Coverage

File Coverage [76.32%] 🍏
WebSocketClientConfig.kt 95.16% 🍏
CachingService.kt 59.86% ❌
Total Project Coverage 73.65% 🍏

@geoandri geoandri changed the title CID-2940 Use 3 max attempts for retrying establishing connection CID-2940 Use 5 max attempts for retrying establishing connection Dec 16, 2024
@geoandri geoandri merged commit 2c9af19 into main Dec 16, 2024
4 checks passed
@geoandri geoandri temporarily deployed to ghcr:leanix-github-agent December 16, 2024 10:42 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henriq-amaral-leanix henriq-amaral-leanix henriq-amaral-leanix approved these changes

Assignees
No one assigned
Labels
chore
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geoandri @henriq-amaral-leanix