Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allSome_length #917

Closed
wants to merge 1 commit into from

Conversation

Smaug123
Copy link

@Smaug123 Smaug123 commented Aug 15, 2024

  • I'm not very fluent with Lean, and there may certainly be better ways to prove this. In particular, I'm using a lot of simp to reduce the unfold.
  • Is your intuition that this will become more ergonomic to use if e.g. the res parameter were made implicit?
  • Should this be simp?

@Smaug123
Copy link
Author

awaiting-review

@github-actions github-actions bot added the awaiting-review This PR is ready for review; the author thinks it is ready to be merged. label Aug 15, 2024
Copy link
Collaborator

@fgdorais fgdorais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These theorems should be in Batteries.Data.List.Lemmas. (Batteries.Data.List.Basic is about definitions, and the occasional lemma that is needed for a later definition.)

@fgdorais fgdorais added awaiting-author Waiting for PR author to address issues and removed awaiting-review This PR is ready for review; the author thinks it is ready to be merged. labels Sep 25, 2024
@Smaug123
Copy link
Author

I'm not convinced this theorem is architecturally the right choice; it seems very special-casey. Something more "if isSome then all the elements are the same", from which this could be deduced, seems more reasonable to me.

@Smaug123 Smaug123 closed this Sep 27, 2024
@Smaug123 Smaug123 deleted the allSome_length branch September 27, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-author Waiting for PR author to address issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants