Skip to content

Commit

Permalink
refactor(Archive/Arithcc): avoid defEq abuse (#16754)
Browse files Browse the repository at this point in the history
the `rfl` was a bit of a defeq abuse: The goal was `StateEqRs a b` for
definitely different terms `a` and `b`, but it was still using
`StateEqRs.refl a`, because then after unfolding `StateEqRs` and doing a
bit of computation the proof held. This would break once
leanprover/lean4#3714
lands, and is a bit fishy in any case so let's just let `simp` handle
it.
  • Loading branch information
nomeata committed Sep 16, 2024
1 parent a949d3d commit 6d17ea3
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions Archive/Arithcc.lean
Original file line number Diff line number Diff line change
Expand Up @@ -279,10 +279,7 @@ theorem compiler_correctness
| const => simp [StateEq, step]; rfl
-- 5.II
| var =>
simp [hmap, StateEq, step] -- Porting note: was `finish [hmap, StateEq, step]`
constructor
· simp_all only [read, loc]
· rfl
simp_all [StateEq, StateEqRs, step]
-- 5.III
| sum =>
rename_i e_s₁ e_s₂ e_ih_s₁ e_ih_s₂
Expand Down

0 comments on commit 6d17ea3

Please sign in to comment.