Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: robustify proof in CategoryTheory.Limit.VanKampen #14635

Closed
wants to merge 2 commits into from

Conversation

kim-em
Copy link
Contributor

@kim-em kim-em commented Jul 11, 2024

Defensive change preparing for leanprover/lean4#4595.

Copy link

github-actions bot commented Jul 11, 2024

PR summary 0bc479ab0f

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

Copy link
Collaborator

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable on its own.
maintainer merge

Mathlib/CategoryTheory/Limits/VanKampen.lean Outdated Show resolved Hide resolved
Copy link

🚀 Pull request has been placed on the maintainer queue by grunweg.

1 similar comment
Copy link

🚀 Pull request has been placed on the maintainer queue by grunweg.

@mattrobball
Copy link
Collaborator

bors delegate+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 11, 2024

✌️ semorrison can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

Co-authored-by: grunweg <rothgami@math.hu-berlin.de>
@kim-em
Copy link
Contributor Author

kim-em commented Jul 11, 2024

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jul 11, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jul 11, 2024
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 11, 2024

Build failed (retrying...):

mathlib-bors bot pushed a commit that referenced this pull request Jul 11, 2024
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 11, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: robustify proof in CategoryTheory.Limit.VanKampen [Merged by Bors] - chore: robustify proof in CategoryTheory.Limit.VanKampen Jul 11, 2024
@mathlib-bors mathlib-bors bot closed this Jul 11, 2024
@mathlib-bors mathlib-bors bot deleted the robustify_vankmapen branch July 11, 2024 14:18
@adomani adomani mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants