-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat: stability of List.insertionSort
#16065
Conversation
PR summary cbd44d5495Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
Otherwise LGTM! |
I've added the stability theorems based on |
Also, leanprover/lean4-nightly@6d0b008 adds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And please add the TODO, yes
eb1abd8
to
d2cf13b
Compare
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
d2cf13b
to
9604c26
Compare
I've changed the theorem names as to align with leanprover/lean4#5242 |
bors merge |
The statements of stability follow those used for `mergeSort` in leanprover/lean4#5092. Co-authored-by: Matthew Ballard <matt@mrb.email>
Pull request successfully merged into master. Build succeeded: |
List.insertionSort
List.insertionSort
The statements of stability follow those used for `mergeSort` in leanprover/lean4#5092. Co-authored-by: Matthew Ballard <matt@mrb.email>
The statements of stability follow those used for
mergeSort
in leanprover/lean4#5092.This PR is a result of this discussion on Zulip, where @semorrison recommended we verify that
List.insertionSort
is stable.