[Merged by Bors] - perf(Linter/Whitespace): revert #26240#34645
Closed
grunweg wants to merge 1 commit intoleanprover-community:masterfrom
Closed
[Merged by Bors] - perf(Linter/Whitespace): revert #26240#34645grunweg wants to merge 1 commit intoleanprover-community:masterfrom
grunweg wants to merge 1 commit intoleanprover-community:masterfrom
Conversation
This causes significant regressions to code with many violations, see e.g. https://leanprover.zulipchat.com/#narrow/channel/113488-general/topic/.60linear_combination.60.20performance.20regression.20in.20v4.2E28.2E0-rc1. Going from srcNat := ls.length to srcNat := ls.positions.count causes a regression, as this could go through the string linearly. Let us revert this change instead; it is not forward-compatible with leanprover-community#30658 anyway.
PR summary fbc09fe073Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
Contributor
|
Thanks for the revert. maintainer merge |
|
🚀 Pull request has been placed on the maintainer queue by joneugster. |
ghost
added
the
maintainer-merge
Contributor
|
Thanks! |
ghost
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jan 31, 2026
This causes significant regressions to code with many violations, see e.g. https://leanprover.zulipchat.com/#narrow/channel/113488-general/topic/.60linear_combination.60.20performance.20regression.20in.20v4.2E28.2E0-rc1. Going from srcNat := ls.length to srcNat := ls.positions.count causes a regression, as this could go through the string linearly. Let us revert this change instead; it is not forward-compatible with #30658 anyway.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
YellPika
pushed a commit
to YellPika/mathlib4
that referenced
this pull request
Feb 3, 2026
…r-community#34645) This causes significant regressions to code with many violations, see e.g. https://leanprover.zulipchat.com/#narrow/channel/113488-general/topic/.60linear_combination.60.20performance.20regression.20in.20v4.2E28.2E0-rc1. Going from srcNat := ls.length to srcNat := ls.positions.count causes a regression, as this could go through the string linearly. Let us revert this change instead; it is not forward-compatible with leanprover-community#30658 anyway.
michaellee94
pushed a commit
to michaellee94/mathlib4
that referenced
this pull request
Feb 15, 2026
…r-community#34645) This causes significant regressions to code with many violations, see e.g. https://leanprover.zulipchat.com/#narrow/channel/113488-general/topic/.60linear_combination.60.20performance.20regression.20in.20v4.2E28.2E0-rc1. Going from srcNat := ls.length to srcNat := ls.positions.count causes a regression, as this could go through the string linearly. Let us revert this change instead; it is not forward-compatible with leanprover-community#30658 anyway.
Maldooor
pushed a commit
to Maldooor/mathlib4
that referenced
this pull request
Feb 25, 2026
…r-community#34645) This causes significant regressions to code with many violations, see e.g. https://leanprover.zulipchat.com/#narrow/channel/113488-general/topic/.60linear_combination.60.20performance.20regression.20in.20v4.2E28.2E0-rc1. Going from srcNat := ls.length to srcNat := ls.positions.count causes a regression, as this could go through the string linearly. Let us revert this change instead; it is not forward-compatible with leanprover-community#30658 anyway.
pfaffelh
pushed a commit
to pfaffelh/mathlib4
that referenced
this pull request
Mar 2, 2026
…r-community#34645) This causes significant regressions to code with many violations, see e.g. https://leanprover.zulipchat.com/#narrow/channel/113488-general/topic/.60linear_combination.60.20performance.20regression.20in.20v4.2E28.2E0-rc1. Going from srcNat := ls.length to srcNat := ls.positions.count causes a regression, as this could go through the string linearly. Let us revert this change instead; it is not forward-compatible with leanprover-community#30658 anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This causes significant regressions to code with many violations, see e.g. https://leanprover.zulipchat.com/#narrow/channel/113488-general/topic/.60linear_combination.60.20performance.20regression.20in.20v4.2E28.2E0-rc1.
Going from srcNat := ls.length to srcNat := ls.positions.count causes a regression, as this could go through the string linearly. Let us revert this change instead; it is not forward-compatible with #30658 anyway.