Skip to content

perf: no expose SplittingField#37474

Draft
Komyyy wants to merge 13 commits intoleanprover-community:masterfrom
Komyyy:no-expose-splitting-field
Draft

perf: no expose SplittingField#37474
Komyyy wants to merge 13 commits intoleanprover-community:masterfrom
Komyyy:no-expose-splitting-field

Conversation

@Komyyy
Copy link
Copy Markdown
Contributor

@Komyyy Komyyy commented Apr 1, 2026


Open in Gitpod

@Komyyy Komyyy added awaiting-bench This PR needs to be benchmarked before merging t-ring-theory Ring theory labels Apr 1, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

PR summary 84b136b1b1

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ algebraCast
+ div
+ instAlgebraAux
+ instAlgebraZModAux
+ instCommRingAux
+ instFieldAux
+ instance (f : K[X]) : CommRing (SplittingField f)
+ instance (f : K[X]) : Inhabited (SplittingField f)
+ instance (f : K[X]) : Nontrivial (SplittingField f)
+ instance (p : ℕ) [Fact p.Prime] (n : ℕ) : Algebra (ZMod p) (GaloisField p n)
+ instance (p : ℕ) [Fact p.Prime] (n : ℕ) : Field (GaloisField p n)
+ instance : CharP (GaloisField p n) p
+ instance : Finite (GaloisField p n)
+ instance : FiniteDimensional (ZMod p) (GaloisField p n)
+ instance : Inhabited (GaloisField p n)
+ instance : IsSplittingField (ZMod p) (GaloisField p n) (X ^ p ^ n - X)
+ intCast
+ natCast
+ nnqsmul
+ nnratCast
+ nsmul
+ qsmul
+ ratCast
+ smul
+ zmodCast
+ zmodsmul
+ zpow
+ zsmul
++ add
++ instance (R : Type*) (f : K[X]) [CommSemiring R] [Algebra R K] :
++ inv
++ mul
++ neg
++ npow
++ one
++ sub
++ zero
- fact_irreducible_factor
- succ

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


Decrease in tech debt: (relative, absolute) = (1.48, 0.01)
Current number Change Type
451 -1 porting notes
631 -2 erw
6894 -3 backward.isDefEq.respectTransparency

Current commit c67b560dd6
Reference commit 84b136b1b1

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Apr 1, 2026
@Komyyy Komyyy added tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip WIP Work in progress and removed t-ring-theory Ring theory awaiting-bench This PR needs to be benchmarked before merging labels Apr 1, 2026
@Komyyy
Copy link
Copy Markdown
Contributor Author

Komyyy commented Apr 1, 2026

!radar

@leanprover-radar
Copy link
Copy Markdown

leanprover-radar commented Apr 1, 2026

Benchmark results for dc015c6 against 84b136b are in. There are no significant changes. @Komyyy

  • 🟥 build//instructions: +28.8G (+0.02%)

Small changes (1✅, 2🟥)

  • build/module/Mathlib.FieldTheory.PolynomialGaloisGroup//instructions: -1.5G (-4.85%)
  • 🟥 build/module/Mathlib.FieldTheory.SplittingField.Construction//instructions: +6.4G (+20.19%) (reduced significance based on *//lines)
  • 🟥 build/module/Mathlib.Lean.PrettyPrinter.Delaborator//instructions: +383.4M (+12.24%)

@Komyyy Komyyy marked this pull request as draft April 1, 2026 14:05
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 1, 2026

This pull request is now in draft mode. No active bors state needed cleanup.

While this PR remains draft, bors will ignore commands on this PR. Mark it ready for review before using commands like bors r+ or bors try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-algebra Algebra (groups, rings, fields, etc) tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip WIP Work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants