Skip to content

feat(Analysis/InnerProductSpace): singleton basis for 1d space#37506

Open
wwylele wants to merge 1 commit intoleanprover-community:masterfrom
wwylele:orth-basis-single
Open

feat(Analysis/InnerProductSpace): singleton basis for 1d space#37506
wwylele wants to merge 1 commit intoleanprover-community:masterfrom
wwylele:orth-basis-single

Conversation

@wwylele
Copy link
Copy Markdown
Collaborator

@wwylele wwylele commented Apr 1, 2026

This was brought up in #36462. Similar to existing FiniteDimensional.basisSingleton, this provides a OrthonormalBasis version.


Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

PR summary c0ee2a9375

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ FiniteDimensional.orthonormalBasisSingleton
+ FiniteDimensional.orthonormalBasisSingleton_apply
+ FiniteDimensional.toBasis_orthonormalBasisSingleton
+ Unique.orthonormal_iff

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-analysis Analysis (normed *, calculus) label Apr 1, 2026
simpa [hij] using h i j

@[simp]
theorem Unique.orthonormal_iff [Unique ι] {v : ι → E} : Orthonormal 𝕜 v ↔ ‖v default‖ = 1 := by
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think of changing this to

Suggested change
theorem Unique.orthonormal_iff [Unique ι] {v : ι → E} : Orthonormal 𝕜 v ↔ ‖v default‖ = 1 := by
theorem orthonormal_subsingleton_iff [Subsingleton ι] {v : ι → E} : Orthonormal 𝕜 v ↔ ∀ i, ‖v i‖ = 1 := by

which then applies to empty families too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-analysis Analysis (normed *, calculus)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants