chore: use a type synonym instead of an abbrev for Interval#37508
chore: use a type synonym instead of an abbrev for Interval#37508sgouezel wants to merge 3 commits intoleanprover-community:masterfrom
Interval#37508Conversation
PR summary 865d150803Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
j-loreaux
left a comment
There was a problem hiding this comment.
Otherwise this looks good to me.
bors d+
Mathlib/Order/Interval/Basic.lean
Outdated
| rfl | ||
|
|
||
| theorem coe_inj : (s : Interval α) = t ↔ s = t := WithBot.coe_inj | ||
|
|
There was a problem hiding this comment.
Doesn't this already appear on Line 314? Note that this is in the root namespace which is why it didn't conflict with the pre-existing one.
Mathlib/Order/Interval/Basic.lean
Outdated
| @[simp, norm_cast] | ||
| lemma coe_le_coe {s t : NonemptyInterval α} : (s : Interval α) ≤ t ↔ s ≤ t := | ||
| WithBot.coe_le_coe |
There was a problem hiding this comment.
This assumes Lattice α, which seems too strong. I think you should move it up into the Preorder section.
|
✌️ sgouezel can now approve this pull request. To approve and merge a pull request, simply reply with |
Otherwise, there are conflicting instances between
Intervaland its definitionWithBot ..., creating diamonds.