doc(RingTheory): avoid lazy continuation lines#37510
Open
harahu wants to merge 1 commit intoleanprover-community:masterfrom
Open
doc(RingTheory): avoid lazy continuation lines#37510harahu wants to merge 1 commit intoleanprover-community:masterfrom
harahu wants to merge 1 commit intoleanprover-community:masterfrom
Conversation
PR summary 865d150803Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
grunweg
reviewed
Apr 1, 2026
Contributor
grunweg
left a comment
There was a problem hiding this comment.
LGTM, except for one comment. Thanks!
bors d+
| * the image of `f` in `K[X]` is a power of `q`. | ||
| * the leading coefficient of `f` is not zero in `K` | ||
| * the polynomial `f` is primitive. | ||
|
|
Contributor
There was a problem hiding this comment.
I'd remove this one --- the following paragraph is not part of the enumeration, but belongs together with the previous items.
Contributor
|
✌️ harahu can now approve this pull request. To approve and merge a pull request, simply reply with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We resolve the ambiguity inherent in lazy (un-indented) list item continuation lines by either indenting them or separating them by inserting a newline in the cases where the item continuation was a mistake.