-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lean-action
template for lake new/init
#4606
Comments
I created #4608 to get started on this. I am waiting for additional input before adding a way for the user to specify if the |
I propose that we actually just include this file regardless of which template the user has asked for. (Possibly with a switch to disable, but I'd very much like this on by default.) |
This makes sense to me. Now that lean-action automatically decides which CI steps to run based on If we always include the workflow file, the template / CLI option question above becomes irrelevant and I believe #4608 should be close to what we want. However if we do want to give users the option to disable the inclusion of the workflow file, the template / CLI option question still stands. The long option, something like |
@austinletson Yep, #4608 seems exactly like what we want here! I left a code review with a few suggested tweaks over there. Also, mentioning the default workflow behavior in the documentation of test and lint drivers sounds like a good idea (though I think we can leave it for a follow-up PR). |
Draft of adding ci workflow using lean-action on `lake new/init` This PR is currently missing lake options for the user to control this feature. Closes #4606 --------- Co-authored-by: Mac Malone <tydeu@hatpress.net>
Proposal
Add a template to
lake new/init
to allow users to automatically include a default continuous integration workflow that uses lean-action.With the
auto-config
improvement introduced by leanprover/lean-action#61, a call tolean-action
with no inputs should be a reasonable default:Here are a few questions regarding implementation and user experience we need to align on:
lake new --lean-action-workflow
) instead of a template make sense? @tydeu I thought you might be the best person to answer this.Community Feedback
link to relevant Zulip discussion
Related to #3950
Add 👍 to issues you consider important. If others benefit from the changes in this proposal being added, please ask them to add 👍 to it.
The text was updated successfully, but these errors were encountered: