Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: create ci workflow on lake new/init #4608

Merged
merged 7 commits into from
Jul 25, 2024
Merged

feat: create ci workflow on lake new/init #4608

merged 7 commits into from
Jul 25, 2024

Conversation

austinletson
Copy link
Contributor

@austinletson austinletson commented Jul 1, 2024 •
edited
Loading

Draft of adding ci workflow using lean-action on lake new/init

This PR is currently missing lake options for the user to control this feature.

Closes #4606

@austinletson austinletson mentioned this pull request Jul 1, 2024
Closed
kim-em
kim-em reviewed Jul 1, 2024
View reviewed changes
src/lake/Lake/CLI/Init.lean Outdated Show resolved Hide resolved
kim-em
kim-em reviewed Jul 1, 2024
View reviewed changes
src/lake/Lake/CLI/Init.lean Outdated Show resolved Hide resolved
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jul 1, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

leanprover-community-mathlib4-bot commented Jul 1, 2024 •
edited
Loading

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase d4d7c72365f9278a384719b176a24cf2adb8e11e --onto f31d4dc1284ad66a40cd3751ad014de4f45aca8d. (2024-07-01 12:27:38)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase d4d7c72365f9278a384719b176a24cf2adb8e11e --onto 5938dbbd14145c9b78f7645c4777f62a3fc8212c. (2024-07-24 12:10:09)

tydeu
tydeu requested changes Jul 24, 2024
View reviewed changes
Copy link
Member

@tydeu tydeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks pretty good to me. 🎉 I just have a few minor tweaks I would like to see.

src/lake/Lake/CLI/Init.lean Outdated Show resolved Hide resolved
src/lake/Lake/CLI/Init.lean Outdated Show resolved Hide resolved
src/lake/Lake/CLI/Init.lean Outdated Show resolved Hide resolved
src/lake/Lake/CLI/Init.lean Outdated Show resolved Hide resolved
tydeu
tydeu approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@tydeu tydeu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Give me a ping (and undraft it) when/if you are satisfied with the PR and I will merge it.

@austinletson austinletson marked this pull request as ready for review July 24, 2024 22:28
@austinletson
Copy link
Contributor Author

@tydeu Thanks for the suggestions! I tested it locally again to make sure it works as intended. Ready to merge 🚀

@tydeu tydeu added this pull request to the merge queue Jul 25, 2024
Merged via the queue into leanprover:master with commit 93fa9c8 Jul 25, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kim-em kim-em kim-em left review comments

@tydeu tydeu tydeu approved these changes

Assignees
No one assigned
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lean-action template for lake new/init
4 participants
@austinletson @leanprover-community-mathlib4-bot @kim-em @tydeu