feat: pretty print level metavariables using index#13030
Open
feat: pretty print level metavariables using index#13030
Conversation
This PR introduces level metavariable indices to the metavariable context and uses these for pretty printing level metavariables. The upshot is that level metavariables pretty print with smaller numerical suffixes, which are per-definition rather than per-module.
Collaborator
|
Reference manual CI status:
|
mathlib-nightly-testing bot
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
Mar 22, 2026
mathlib-nightly-testing bot
pushed a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Mar 22, 2026
|
Mathlib CI status (docs):
|
|
Mathlib CI status (docs):
|
|
Mathlib CI status (docs):
|
Collaborator
Author
|
!bench |
|
Benchmark results for 0f5705a against 87180a0 are in. Significant changes detected! @kmill
Medium changes (2🟥)
Small changes (76🟥) Too many entries to display here. View the full report on radar instead. |
mathlib-nightly-testing bot
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
Mar 22, 2026
mathlib-nightly-testing bot
pushed a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Mar 22, 2026
|
Mathlib CI status (docs):
|
Collaborator
Author
|
!bench |
|
Benchmark results for 23bb157 against 87180a0 are in. There are no significant changes. @kmill
Small changes (5✅, 7🟥)
|
|
Mathlib CI status (docs):
|
|
Mathlib CI status (docs):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves pretty printing of level metavariables: they now print with a per-definition index rather than their per-module internal identifiers. Furthermore,
+is printed uniformly in level expressions with surrounding spaces. Breaking change: level pretty printing should usedelabLevelorMessageData.ofLevel, since functions such asformatortoStringwill now print metavariables with raw internal identifiers, as the indices are stored in the current metacontext. The heartbeat counter also increases quicker from counting allocations recording level metavariable indices. In some tests we needed to increasemaxHeartbeatsby 20–50% to compensate, without observing a slowdown.