chore: add missing std::move and std::forward calls#13049
Open
jlebar wants to merge 1 commit intoleanprover:masterfrom
Open
chore: add missing std::move and std::forward calls#13049jlebar wants to merge 1 commit intoleanprover:masterfrom
jlebar wants to merge 1 commit intoleanprover:masterfrom
Conversation
jlebar
changed the title
jlebar
changed the title
Also fix a few places where we were using std::forward<T> when we should have been using std::move. This PR was written by Codex with ChatGPT 5.4 high, but I manually verified the changes myself. Specifically, I pointed Codex at leanprover#4698 and asked it to find the remaining missing changes in this vein. I also ran clang-tidy over the repo to verify that this caught all of the missing std::move's. Fixes leanprover#4698.
github-actions
bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
Member
|
!radar |
|
Benchmark results for 9bed004 against 98f5266 are in. There are no significant changes. @TwoFX @jlebar
No significant changes detected. |
eric-wieser
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fix a few places where we were using std::forward when we should
have been using std::move.
This PR was written by Codex with ChatGPT 5.4 high, but I manually
verified the changes myself. Specifically, I pointed Codex at
#4698 and asked it to find the
remaining missing changes in this vein. I also ran clang-tidy over the
repo to verify that this caught all of the missing std::move's.
Fixes #4698.