feat: expire idle task pool threads after 5 seconds#13123
Draft
Kha wants to merge 1 commit intoleanprover:masterfrom
Draft
feat: expire idle task pool threads after 5 seconds#13123Kha wants to merge 1 commit intoleanprover:masterfrom
Kha wants to merge 1 commit intoleanprover:masterfrom
Conversation
This PR makes the task thread pool reclaim idle worker threads after 5 seconds of inactivity. Previously, pool threads were allocated on demand but never freed, which wastes significant memory given the default 1GB stack size per thread. Worker threads are now detached immediately after creation instead of being stored in a vector. Each idle thread uses a timed wait and exits if no work arrives within the timeout. The destructor waits on a counter instead of joining stored threads. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Member
Author
|
!bench |
|
Benchmark results for d567797 against 6f98a76 are in. Significant changes detected! @Kha
Large changes (2🟥)
Medium changes (1✅, 7🟥)
Small changes (1✅, 301🟥) Too many entries to display here. View the full report on radar instead. |
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the task thread pool reclaim idle worker threads after 5 seconds of inactivity. Previously, pool threads were allocated on demand but never freed, which could waste significant memory given the new default 1GB stack size per thread.
Worker threads are now detached immediately after creation instead of being stored in a vector. Each idle thread uses a timed wait and exits if no work arrives within the timeout. The destructor waits on a counter instead of joining stored threads.