fix: use correct shared library directory for Lake plugin on Windows#13128
Open
fix: use correct shared library directory for Lake plugin on Windows#13128
Conversation
This PR fixes the Windows dev build by using `CMAKE_RELATIVE_LIBRARY_OUTPUT_DIRECTORY` instead of the hardcoded `lib/lean` path for the Lake plugin. On Windows, DLLs must be placed next to executables in `bin/`, but the plugin path was hardcoded to `lib/lean`. Closes #13126 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
tydeu
approved these changes
Mar 26, 2026
github-actions
bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
Kha
added
the
release-ci
Contributor
|
The fsanitize error here is on me as I needed to do a multi PR setup to fix some stage0 issues yesterday and I wasn't able to fully go through with it yet, I'll finish that up today. The Windows CI is just broken I think? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the Windows dev build by using
CMAKE_RELATIVE_LIBRARY_OUTPUT_DIRECTORYinstead of the hardcodedlib/leanpath for the Lake plugin. On Windows, DLLs must be placed next to executables inbin/, but the plugin path was hardcoded tolib/lean, causing stage0 DLLs to not be found.The
CMAKE_RELATIVE_LIBRARY_OUTPUT_DIRECTORYvariable was introduced precisely for this purpose — it resolves tobinon Windows andlib/leanelsewhere.Closes #13126
🤖 Prepared with Claude Code