refactor: clean up public API around Array.eraseIdx
#3676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: `Array.eraseIdxAux` and `Array.eraseIdxSzAux` were clearly not intended to remain public, but simply making them private would make it inconvenient to unfold them when writing proofs in Std.
`Array.eraseIdx'` which was just `Array.feraseIdx` wrapped in a subtype. `Array.size_feraseIdx` proves the property as a standalone theorem.
timotree3
force-pushed
the
cleanup-array
branch
from
b2428e8 to
426d6bc
Compare
github-actions
bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
|
awaiting-review |
github-actions
bot
added
the
awaiting-review
|
BTW porting over the lemma from my std4 PR leanprover-community/batteries#690 was pretty easy: https://github.com/Seppel3210/std4/commit/109c3ce97e182813a166c9b55418d9a599a01bb6 I also think this makes the API nicer |
Seppel3210
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Array.eraseIdxAuxandArray.eraseIdxSzAuxwhich were implementation details.Array.eraseIdxAuxandArray.eraseIdxSzAuxwere clearly not intended to remain public, but simply making them private would make it inconvenient to unfold them when writing proofs in Std.Array.eraseIdx-related definitions which remain.Array.eraseIdx'which was justArray.feraseIdxwrapped in a subtype and addsArray.size_feraseIdxto prove the subtype property as a standalone theorem.Co-Authored-By: Daniel Windham daniel@atlascomputing.org