Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: calling programs with spaces on Windows #4515

Merged
merged 12 commits into from
Jul 26, 2024
Merged

fix: calling programs with spaces on Windows #4515

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
c676bb8
fix: calling programs with spaces on Windows?
Kha Jun 20, 2024
6d42240
bisect
Kha Jun 20, 2024
3a7b7a5
try breaking it first
Kha Jun 20, 2024
bc8c4cf
fix
Kha Jun 20, 2024
45273cf
fix: cmake doesn't want the spaces either
Kha Jun 21, 2024
9cab077
oh
Kha Jun 21, 2024
632030a
Update tests/pkg/spaces/test.sh
Kha Jul 1, 2024
78d0819
make sure prefix of spaces path exists
Kha Jul 24, 2024
210da25
fix
Kha Jul 24, 2024
c3a7bb0
fix?
Kha Jul 24, 2024
37b656d
refix
Kha Jul 25, 2024
2dfdc45
clean up
Kha Jul 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/runtime/process.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,9 @@ static obj_res spawn(string_ref const & proc_name, array_ref<string_ref> const &

// Create the child process.
bool bSuccess = CreateProcess(
program.c_str(),
// Passing `program` here should be more robust, but would require adding a `.exe` extension
// where necessary
NULL, //program.c_str(),
Kha marked this conversation as resolved.
Show resolved Hide resolved
const_cast<char *>(command.c_str()), // command line
NULL, // process security attributes
NULL, // primary thread security attributes
Expand Down
Loading