Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make import resolution case-sensitive on all platforms #4538

Merged
merged 9 commits into from
Jul 31, 2024
Merged

fix: make import resolution case-sensitive on all platforms #4538

merged 9 commits into from
Jul 31, 2024

Conversation

Kha
Copy link
Member

@Kha Kha commented Jun 23, 2024

No description provided.

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jun 23, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Jun 23, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#4538
6843080
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Jun 23, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#4538
ed4ff79
@leanprover-community-mathlib4-bot
Copy link
Collaborator

leanprover-community-mathlib4-bot commented Jun 23, 2024 •
edited
Loading

Mathlib CI status (docs):

leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Jun 23, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4538
f7c6b90
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Jun 23, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4538
4d22c62
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Jun 23, 2024
@Kha Kha added this pull request to the merge queue Jun 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 27, 2024
@Kha Kha added this pull request to the merge queue Jul 24, 2024
@Kha Kha removed this pull request from the merge queue due to a manual request Jul 24, 2024
@Kha Kha added the release-ci Enable all CI checks for a PR, like is done for releases label Jul 24, 2024
@Kha Kha requested a review from tydeu as a code owner July 26, 2024 07:40
Kha
Kha commented Jul 26, 2024
View reviewed changes
src/lake/Lake/Build/Module.lean Outdated Show resolved Hide resolved
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Jul 26, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4538
97c2fd5
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Jul 26, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4538
5f1b83c
@Kha @tydeu
Update src/lake/Lake/Build/Module.lean
49b595b 
Co-authored-by: Mac Malone <tydeu@hatpress.net>
@Kha Kha enabled auto-merge July 31, 2024 09:44
@tydeu
chore: update test.sh
123efa6 
Adapt to new error message.
@Kha Kha added this pull request to the merge queue Jul 31, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Jul 31, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4538
d290291
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Jul 31, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4538
868d9ca
Merged via the queue into leanprover:master with commit d5a8c96 Jul 31, 2024
22 checks passed
Kha added a commit that referenced this pull request Aug 1, 2024
@Kha
Revert "fix: make import resolution case-sensitive on all platforms (#…
df84536 
…4538)"

This reverts commit d5a8c96.
@Kha Kha mentioned this pull request Aug 1, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Aug 1, 2024
@Kha
chore: revert "fix: make import resolution case-sensitive on all plat…
5e6a3cf 
…forms" (#4896)

Reverts #4538 because of unexpected overhead
@Kha Kha mentioned this pull request Sep 27, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tydeu tydeu tydeu approved these changes

Assignees
No one assigned
Labels
builds-mathlib CI has verified that Mathlib builds against this PR release-ci Enable all CI checks for a PR, like is done for releases toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kha @leanprover-community-mathlib4-bot @tydeu