feat: trailing whitespace changes should not invalidate imports #4580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
nomeata
reviewed
Jun 28, 2024
Comment on lines
+417
to
+418
| -- to uphold the invariant that concatenating all top-level snapshots' syntax trees results in | ||
| -- the original file. |
There was a problem hiding this comment.
Just curious: Is that an invariant that we enforce somehow? Do we have tests for that?
There was a problem hiding this comment.
We don't make use of it currently as far as I know (there isn't even a function for the concatenation). When we do, we should add tests.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 24, 2024
Thus, starting to type the first declaration after the imports should not make them reload
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thus, starting to type the first declaration after the imports should not make them reload