Skip to content

fix: do not ban .. with a . on the next line #4768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kha merged 3 commits into from
Sep 17, 2024
Merged

fix: do not ban .. with a . on the next line #4768

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bb66d4d
fix: do not ban `..` with a `.` on the next line
eric-wieser Jul 17, 2024
e4f6939
fix the test
eric-wieser Aug 5, 2024
3d9bf22
Add test docstring
eric-wieser Aug 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Lean/Parser/Term.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -752,7 +752,7 @@ We use them to implement `macro_rules` and `elab_rules`
def namedArgument := leading_parser (withAnonymousAntiquot := false)
atomic ("(" >> ident >> " := ") >> withoutPosition termParser >> ")"
def ellipsis := leading_parser (withAnonymousAntiquot := false)
".." >> notFollowedBy "." "`.` immediately after `..`"
".." >> notFollowedBy (checkNoWsBefore >> ".") "`.` immediately after `..`"
def argument :=
checkWsBefore "expected space" >>
checkColGt "expected to be indented" >>
Expand Down
10 changes: 10 additions & 0 deletions tests/lean/run/4768.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
/-!
Test that `..` tokens do not break nearby `.`s.

Note that this tests specifically for issues with `.` that are not present with `·`.
-/

example : True ∧ True := by
constructor
refine trivial ..
. trivial -- this has to be . not · for this test to be useful