Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: find? and findExt? #4795

Merged
merged 1 commit into from
Jul 20, 2024
Merged

perf: find? and findExt? #4795

merged 1 commit into from
Jul 20, 2024

Conversation

leodemoura
Copy link
Member

use the kernel implementation.

@leodemoura
perf: find? and findExt?
8485578 
use kernel implementation
@leodemoura leodemoura enabled auto-merge July 20, 2024 00:57
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc July 20, 2024 01:08 Inactive
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jul 20, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 327986e6fb4790a10bf5eba841ce61b6a7b96b7e --onto 78c4d6daff4b500a57cf22dfa3f49e00489827c5. (2024-07-20 01:13:51)

@leodemoura leodemoura added this pull request to the merge queue Jul 20, 2024
Merged via the queue into master with commit de5e07c Jul 20, 2024
13 checks passed
nomeata added a commit to leanprover-community/mathlib4 that referenced this pull request Jul 21, 2024
@nomeata
Adaption to leanprover/lean4#4795
25e9caa
nomeata added a commit to leanprover-community/mathlib4 that referenced this pull request Jul 21, 2024
@nomeata
Refine adaption to leanprover/lean4#4795 (less code needed)
9aed705
nomeata added a commit to leanprover-community/mathlib4 that referenced this pull request Jul 21, 2024
@nomeata
refactor(Tactic/ToAdditive): do not use the FindM removed in lean4
0885106 
this code was using an internal data type from Lean4 that was
removed in leanprover/lean4#4795
so let's inline the three lines that we need here.
@nomeata nomeata mentioned this pull request Jul 21, 2024
Closed
nomeata added a commit to leanprover-community/mathlib4 that referenced this pull request Jul 21, 2024
@nomeata
refactor(Tactic/ToAdditive): do not use the FindM removed in lean4
2d4d0d8 
this code was using an internal data type from Lean4 that was
removed in leanprover/lean4#4795
so let's inline the three lines that we need here.

This is from #14970
mathlib-bors bot pushed a commit to leanprover-community/mathlib4 that referenced this pull request Jul 21, 2024
@nomeata
refactor(Tactic/ToAdditive): avoid FindM, got removed in lean4 (#14970)
2b52c92 
this code was using an internal data type from Lean4 that was removed in leanprover/lean4#4795 so let's inline the three lines that we need here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leodemoura @leanprover-community-mathlib4-bot