Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: kernel replace with precise cache #4796

Merged
merged 3 commits into from
Jul 20, 2024
Merged

perf: kernel replace with precise cache #4796

merged 3 commits into from
Jul 20, 2024

Conversation

leodemoura
Copy link
Member

Changes:

  • We avoid the thread local storage.
  • We use a hash map to ensure that cached values are not lost.
  • We remove check_system. If this becomes an issue in the future we should precompute the remaining amount of stack space, and use a cheaper check.
  • We add a Expr.replaceImpl, and will use it to implement Expr.replace after update-stage0

@leodemoura leodemoura enabled auto-merge July 20, 2024 01:44
@leodemoura leodemoura disabled auto-merge July 20, 2024 01:45
It uses the kernel implementation.
We will replace `Expr.replace` with it after update-stage0
@leodemoura leodemoura enabled auto-merge July 20, 2024 01:46
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc July 20, 2024 01:55 Inactive
@leodemoura leodemoura added this pull request to the merge queue Jul 20, 2024
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jul 20, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase de5e07c4d2d0b48dce5cefdb629bc7171134b490 --onto 78c4d6daff4b500a57cf22dfa3f49e00489827c5. (2024-07-20 02:02:56)

Merged via the queue into master with commit 726e162 Jul 20, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants