Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use usize for array types #4802

Merged
merged 1 commit into from
Jul 21, 2024
Merged

feat: use usize for array types #4802

merged 1 commit into from
Jul 21, 2024

Conversation

fgdorais
Copy link
Contributor

@fgdorais fgdorais commented Jul 21, 2024 •
edited
Loading

This is part 2 of 2 of #4801 (which closes #4654). That PR was split in two to allow a stage0 update between declaring the usize functions and using them where they are needed.

@fgdorais fgdorais changed the title feat: use usize for arrays feat: use usize for array types Jul 21, 2024
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jul 21, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 3a309f7691329d1f0e786c57bdca06be5f1de2d9 --onto 78c4d6daff4b500a57cf22dfa3f49e00489827c5. (2024-07-21 11:29:48)

@fgdorais fgdorais marked this pull request as ready for review July 21, 2024 11:31
@fgdorais fgdorais requested a review from kim-em as a code owner July 21, 2024 11:31
@fgdorais
Copy link
Contributor Author

awaiting-review

@github-actions github-actions bot added the awaiting-review Waiting for someone to review the PR label Jul 21, 2024
@nomeata nomeata added this pull request to the merge queue Jul 21, 2024
Merged via the queue into leanprover:master with commit 99f3629 Jul 21, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kim-em kim-em Awaiting requested review from kim-em kim-em is a code owner

Assignees
No one assigned
Labels
awaiting-review Waiting for someone to review the PR toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RFC: Array.usize
3 participants
@fgdorais @leanprover-community-mathlib4-bot @nomeata