Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: unnecessary termination_by clauses cause warnings, not errors #4809

Merged
merged 1 commit into from
Jul 22, 2024
Merged

feat: unnecessary termination_by clauses cause warnings, not errors #4809

merged 1 commit into from
Jul 22, 2024

Conversation

nomeata
Copy link
Collaborator

@nomeata nomeata commented Jul 22, 2024

fixes #4804

@nomeata nomeata added the will-merge-soon …unless someone speaks up label Jul 22, 2024
@nomeata nomeata enabled auto-merge July 22, 2024 20:35
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc July 22, 2024 20:43 Inactive
@nomeata nomeata added this pull request to the merge queue Jul 22, 2024
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jul 22, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 3a4d2cded30beb3343ba0e13a3ddb2809703e26d --onto 22ae04f3e7ea716c4af5cfbab587370d10cc06fa. (2024-07-22 20:54:43)

Merged via the queue into master with commit 20c8571 Jul 22, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN will-merge-soon …unless someone speaks up
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

option to downgrade unused termination hint error to a warning
2 participants
@nomeata @leanprover-community-mathlib4-bot