fix: make cdot anonymous function notation handle ambiguous notation#4833
Merged
kmill merged 4 commits intoleanprover:masterfrom Aug 9, 2024
Merged
fix: make cdot anonymous function notation handle ambiguous notation#4833kmill merged 4 commits intoleanprover:masterfrom
kmill merged 4 commits intoleanprover:masterfrom
Conversation
github-actions
bot
added
the
toolchain-available
ghost
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
Jul 25, 2024
ghost
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jul 25, 2024
ghost
added
breaks-mathlib
|
Mathlib CI status (docs):
|
ghost
added
builds-mathlib
ghost
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
Jul 25, 2024
ghost
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jul 25, 2024
Fixes an issue where each alternative in choice nodes would get their own arguments. Now cdot function expansion is aware of choice nodes. Also modifies the variable naming so that multi-argument functions like `(· + ·)` expand as `fun x1 x2 => x1 + x2` rather than `fun x x_1 => x + x_1`. Closes leanprover#4832
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where each alternative in choice nodes would get their own arguments. Now cdot function expansion is aware of choice nodes.
Also modifies the variable naming so that multi-argument functions like
(· + ·)expand asfun x1 x2 => x1 + x2rather thanfun x x_1 => x + x_1.Closes #4832