-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improve proof search in IndPredBelow #4840
base: master
Are you sure you want to change the base?
Conversation
`MVarId.apply` is clever in the order it returns mvars, by putting those arising from non-dependent arguments first. If we lean on that behavior, this fixes #1672.
Mathlib CI status (docs):
|
m.apply ctor | ||
let ms ← m.apply ctor | ||
trace[Meta.IndPredBelow] "new goals {ms}" | ||
pure ms.reverse |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change broke some other tests, until I added the reverse
here; now the existing tests succeed. 🤷
Note to my future self:
I wonder if this just means that for any order of mvars we’ll have examples where it fails, or if there is really a reason why this order is good™. I’ll have to come back to this and think about it some more.
Maybe I’ll also investigate if we avoid proof search here and build the necessary terms direct, relying on the structure of the .ibelow
construction.
MVarId.apply
is clever in the order it returns mvars, by putting thosearising from non-dependent arguments first. If we lean on that behavior,
this fixes #1672.
H'T to @DanielFabian, this was found together in a call.
Also improves tracing.