Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: instantiateExprMVars #4915

Merged
merged 4 commits into from
Aug 5, 2024
Merged

perf: instantiateExprMVars #4915

merged 4 commits into from
Aug 5, 2024

Conversation

leodemoura
Copy link
Member

@leodemoura leodemoura commented Aug 5, 2024

TODO:

  • Support for zeta := true at apply_beta.
  • Investigate test failure.
  • Break PR in pieces because of bootstrapping issues. The current PR updates a stage0 file to workaround the issue.

Motivation: significant performance improvement at https://github.com/leanprover/LNSym/blob/proof_size_expt/Proofs/SHA512/Experiments/Sym30.lean

With M1 Pro:

  • Before: 4.56 secs
  • After: 3.16 secs

Successfully built stage2 using this PR

implemented in C/C++.
TODO: same for `instantiateExprMVars`
@leodemoura leodemoura marked this pull request as draft August 5, 2024 03:54
@github-actions github-actions bot added changes-stage0 Contains stage0 changes, merge manually using rebase toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN labels Aug 5, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 21b4377d36be6f787dcbb41f09ae8f9611d8bb26 --onto 647a5e94925791f6a16b629b6c16ffad60a7f478. (2024-08-05 04:10:04)

@github-actions github-actions bot removed the changes-stage0 Contains stage0 changes, merge manually using rebase label Aug 5, 2024
@leodemoura leodemoura marked this pull request as ready for review August 5, 2024 17:00
@leodemoura
Copy link
Member Author

  • Support for zeta := true at apply_beta. Done
  • Investigate test failure. Done
  • Break PR in pieces because of bootstrapping issues. The current PR updates a stage0 file to workaround the issue. Done

Will merge this PR, run update stage0, and then create new PR with MetavarContext.lean modifications.

@leodemoura leodemoura enabled auto-merge August 5, 2024 17:02
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc August 5, 2024 17:10 Inactive
@leodemoura leodemoura added this pull request to the merge queue Aug 5, 2024
Merged via the queue into master with commit 8e476e9 Aug 5, 2024
13 checks passed
github-merge-queue bot pushed a commit that referenced this pull request Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants